Explicitly build with O2 to avoid build errors #45201

smuzaffar · 2024-06-11T22:31:58Z

This should fix the build errors for NONLTO IBs which were first shown when we enabled -O3. This might be relatged to https://rkoucha.fr/tech_corner/nonnull_gcc_attribute.html ( as mentioned here ). This change explicitly use -O2 for the source files which failed to compile using -O3. Otherwise option is that we use -Wno-error=nonnull which will turn the build error in to warning.

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_NONLTO_X_2024-06-11-1100/Geometry/HGCalCommonData

In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/specfun.h:45,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/cmath:1935,
                 from src/DataFormats/Math/interface/angle_units.h:4,
                 from src/Geometry/HGCalCommonData/plugins/DDHGCalPassive.cc:6:
In static member function 'static _Tp* std::__copy_move<_IsMove, true, std::random_access_iterator_tag>::__copy_m(const _Tp*, const _Tp*, _Tp*) [with _Tp = double; bool _IsMove = false]',
    inlined from '_OI std::__copy_move_a2(_II, _II, _OI) [with bool _IsMove = false; _II = const double*; _OI = double*]' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_algobase.h:495:30,
    inlined from '_OI std::__copy_move_a1(_II, _II, _OI) [with bool _IsMove = false; _II = const double*; _OI = double*]' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_algobase.h:522:42,
    inlined from '_OI std::__copy_move_a(_II, _II, _OI) [with bool _IsMove = false; _II = const double*; _OI = double*]' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_algobase.h:529:31,
    inlined from '_OI std::copy(_II, _II, _OI) [with _II = const double*; _OI = double*]' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_algobase.h:620:7,
    inlined from 'void std::vector<_Tp, _Alloc>::_M_assign_aux(_ForwardIterator, _ForwardIterator, std::forward_iterator_tag) [with _ForwardIterator = const double*; _Tp = double; _Alloc = std::allocator<double>]' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/vector.tcc:330:19:
  /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_algobase.h:431:30: error: argument 1 null where non-null expected [-Werror=nonnull]
   431 |             __builtin_memmove(__result, __first, sizeof(_Tp) * _Num);
      |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

cmsbuild · 2024-06-11T22:32:21Z

cms-bot internal usage

smuzaffar · 2024-06-11T22:32:22Z

please test for CMSSW_14_1_NONLTO_X

cmsbuild · 2024-06-11T22:35:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45201/40550

This PR adds an extra 16KB to repository

cmsbuild · 2024-06-11T22:36:22Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

Geometry/HGCalCommonData (upgrade, geometry)

@makortel, @srimanob, @mdhildreth, @civanch, @Dr15Jones, @subirsarkar, @bsunanda can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-06-12T02:39:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011707/39843/summary.html
COMMIT: e93aca9
CMSSW: CMSSW_14_1_NONLTO_X_2024-06-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45201/39843/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 73 lines to the logs
Reco comparison results: 12806 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3339600
DQMHistoTests: Total failures: 11318
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3328256
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.008000000000000004 KiB( 47 files compared)
DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 141.042 ): 0.035 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 141.044 ): -0.023 KiB JetMET/SUSYDQM
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

srimanob · 2024-06-12T05:41:49Z

Hi @smuzaffar
Do we expect many failures from the change of optimization level? Thx.

smuzaffar · 2024-06-12T06:21:53Z

please test

@srimanob , #45201 (comment) is comparison between LTO and NONLTO builds, so yes the comparison differences are expected. I have restarted the tests for master/default/lto IB and there should not be any differences

cmsbuild · 2024-06-12T09:17:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-011707/39846/summary.html
COMMIT: e93aca9
CMSSW: CMSSW_14_1_X_2024-06-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45201/39846/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3339600
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3339577
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

civanch · 2024-06-13T04:49:23Z

+1

srimanob · 2024-06-13T04:50:41Z

+Upgrade

Thanks @smuzaffar

cmsbuild · 2024-06-13T04:51:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-06-13T15:04:29Z

+1

Explicitly build with O2 to avoid build errors

e93aca9

cmsbuild added this to the CMSSW_14_1_X milestone Jun 11, 2024

cmsbuild added geometry-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Jun 11, 2024

cmsbuild added tests-started and removed tests-pending labels Jun 11, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 11, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 12, 2024

cmsbuild added tests-started and removed tests-approved labels Jun 12, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 12, 2024

cmsbuild added geometry-approved and removed geometry-pending labels Jun 13, 2024

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Jun 13, 2024

cmsbuild added orp-approved and removed orp-pending labels Jun 13, 2024

cmsbuild merged commit d0c5d92 into cms-sw:master Jun 13, 2024
17 checks passed

This was referenced Jun 13, 2024

MTD geometry: fix BTL numbering scheme for scenario v3, input by Geant4, move unit tests to D110 scenario #45211

Merged

Heterogeneous Workflow (CLUE) in Phase2 HLT Simplified Menu #45178

Merged

smuzaffar mentioned this pull request Jun 14, 2024

workaround for -O3 compilation issues in Geometry/HGCalCommonData #45219

Merged

dan131riley pushed a commit to dan131riley/cmssw that referenced this pull request Jun 14, 2024

revert cms-sw#45201

fb592a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Explicitly build with O2 to avoid build errors #45201

Explicitly build with O2 to avoid build errors #45201

smuzaffar commented Jun 11, 2024

cmsbuild commented Jun 11, 2024 •

edited

Loading

smuzaffar commented Jun 11, 2024

cmsbuild commented Jun 11, 2024

cmsbuild commented Jun 11, 2024

cmsbuild commented Jun 12, 2024

srimanob commented Jun 12, 2024

smuzaffar commented Jun 12, 2024

cmsbuild commented Jun 12, 2024

civanch commented Jun 13, 2024

srimanob commented Jun 13, 2024

cmsbuild commented Jun 13, 2024

rappoccio commented Jun 13, 2024

Explicitly build with O2 to avoid build errors #45201

Explicitly build with O2 to avoid build errors #45201

Conversation

smuzaffar commented Jun 11, 2024

cmsbuild commented Jun 11, 2024 • edited Loading

smuzaffar commented Jun 11, 2024

cmsbuild commented Jun 11, 2024

cmsbuild commented Jun 11, 2024

cmsbuild commented Jun 12, 2024

Comparison Summary

srimanob commented Jun 12, 2024

smuzaffar commented Jun 12, 2024

cmsbuild commented Jun 12, 2024

Comparison Summary

civanch commented Jun 13, 2024

srimanob commented Jun 13, 2024

cmsbuild commented Jun 13, 2024

rappoccio commented Jun 13, 2024

cmsbuild commented Jun 11, 2024 •

edited

Loading